Skip to content

🎨 Palette: Make category rows fully clickable and accessible#97

Open
acebytes wants to merge 1 commit intomainfrom
palette-category-row-accessibility-11900948141985423801
Open

🎨 Palette: Make category rows fully clickable and accessible#97
acebytes wants to merge 1 commit intomainfrom
palette-category-row-accessibility-11900948141985423801

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 7, 2026

  • 💡 What: Wrapped the CategoryRow's HStack in a Button, used .contentShape(Rectangle()) to make the empty space clickable. Added .accessibilityElement(children: .combine) and .accessibilityAddTraits(.isSelected).
  • 🎯 Why: Previously, only the small checkbox icon could be tapped, which reduced usability due to a small hit target. Now the entire row can be tapped to toggle the selection, which feels like a native macOS list, while vastly improving accessibility for VoiceOver.
  • 📸 Before/After: Not applicable (invisible hit-target and VoiceOver changes).
  • ♿ Accessibility: Combined children for VoiceOver to read the row naturally as a single element and added the .isSelected trait to announce state correctly.

PR created automatically by Jules for task 11900948141985423801 started by @acebytes

@google-labs-jules @acebytes
🎨 Palette: Make category rows fully clickable and accessible
f78b326 
Wrapped the CategoryRow's HStack in a Button and used `.contentShape(Rectangle())` to make the entire row clickable rather than just the small checkbox. Added `.accessibilityElement(children: .combine)` and `.accessibilityAddTraits(.isSelected)` to ensure VoiceOver correctly reads the whole row and announces its selection state.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

google-labs-jules bot commented Apr 7, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@acebytes